Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Name should be required for embedded images #68

Closed
bbottema opened this issue Mar 11, 2017 · 1 comment
Closed

Bug: Name should be required for embedded images #68

bbottema opened this issue Mar 11, 2017 · 1 comment
Assignees
@bbottema
Labels
bug Priority-High
Milestone
4.2.0

Comments

@bbottema
Copy link
Owner

Since embedded images are always referred to by name, this should be required always. Currently this check is missing when creating a new email, silently failing and resulting in a missing image in the email.
@bbottema bbottema added this to the 4.2.1 milestone Mar 11, 2017
@bbottema bbottema self-assigned this Mar 11, 2017
bbottema referenced this issue Mar 11, 2017
@bbottema
- fixed NullPointerException for missing name when adding attachments
686b736 
- more rigorous checks for missing names when embedding images
- added more convenience methods for adding multiple to's, cc's or bcc's with the EmailBuilder
- added lots of @nullable and @nonnull hint annotations
- added a bunch of unit tests
@bbottema
Copy link
Owner Author

Released in v4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
bug Priority-High
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
1 participant
@bbottema