Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Yarn #8761

Closed
1 task
jroebu14 opened this issue Jan 20, 2021 · 0 comments · Fixed by #8762
Closed
1 task

Migrate to Yarn #8761

jroebu14 opened this issue Jan 20, 2021 · 0 comments · Fixed by #8762
Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features

Comments

@jroebu14
Copy link

jroebu14 commented Jan 20, 2021

Is your feature request related to a problem? Please describe.
We use npm-force-resolutions to prevent security vulnerabilities within certain versions of packages entering our builds. npm-force-resolutions is run on the preinstall script instead of install which in certain situations allows security vulnerabilities to creep back into our builds.

Describe the solution you'd like
Switch to Yarn which has first-class support for forced resolutions https://classic.yarnpkg.com/en/docs/selective-version-resolutions/

Potential issues:

More info:

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Note: Updating to yarn will also allow us to start removing the resolve.alias section of our webpack:

alias: {

@jroebu14 jroebu14 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. technical-work Technical debt, support work and building new technical tools and features cross-team For visibility for both World Service teams (Engage & Media) labels Jan 20, 2021
This was referenced Jan 20, 2021
@jroebu14 jroebu14 removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team For visibility for both World Service teams (Engage & Media) technical-work Technical debt, support work and building new technical tools and features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant