Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top navigation bottom border #6602

Closed
1 task done
FK78 opened this issue May 21, 2020 · 1 comment · Fixed by #7305
Closed
1 task done

Remove top navigation bottom border #6602

FK78 opened this issue May 21, 2020 · 1 comment · Fixed by #7305
Assignees
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) ux To be reviewed by UX before merging

Comments

@FK78
Copy link
Contributor

FK78 commented May 21, 2020

NB - this issue exists within Psammead, not Simorgh

Simorgh PR - #7305
Psammead PR - BBC-archive/psammead#3628
Version bump PR - BBC-archive/psammead#3629

Describe the bug
There is a 1px pink line below the seconday nav bar that needs to be removed. It wasn’t intended design but a technical limitation - the way the component was built to allow the items in the nav wrapping over two lines meant that the line couldn’t stretch over 1280px.

We also have an additonal px of padding below the hover state of the News nav bar.

This impacts all page types.

This issue might be related to this #5864

To Reproduce
Steps to reproduce the behaviour:

  1. Go to any Simorgh page
  2. See issues mentioned above.

Expected behaviour
There should be no padding between the hover state on the News nav bar and the pink line below the secondary nav should be removed.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
If picked up by ws-stories or ws-media speak to ws-home for more context as they built this component.
Denis Hernandez worked on the nav so may be good to consult with him when picking this up.

@FK78 FK78 added bug Something isn't working ws-articles Tasks for the WS Articles Team ws-home ws-media World Service Media ux To be reviewed by UX before merging labels May 21, 2020
@FK78 FK78 added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label May 21, 2020
@HarveyPeachey HarveyPeachey removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jun 5, 2020
@DenisHdz
Copy link
Contributor

DenisHdz commented Jun 8, 2020

For context, this is not a line, but a border-bottom we apply to each list item in the navigation, so when the navigation breaks into different lines, they have a separator in between:

nav

The colour used is C_POSTBOX with 30% of transparency https://github.com/bbc/psammead/blob/latest/packages/components/psammead-navigation/src/index.jsx#L30

@karinathomasbbc karinathomasbbc added cross-team For visibility for both World Service teams (Engage & Media) and removed ws-articles Tasks for the WS Articles Team ws-media World Service Media labels Jul 20, 2020
@RichardPK RichardPK self-assigned this Jul 21, 2020
@RichardPK RichardPK changed the title Navigation display and padding Remove navigation bottom border Jul 23, 2020
@RichardPK RichardPK changed the title Remove navigation bottom border Remove top navigation bottom border Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cross-team For visibility for both World Service teams (Engage & Media) ux To be reviewed by UX before merging
Projects
None yet
6 participants