Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heading added below media for MAP #4403

Closed
1 task done
ryanmccombe opened this issue Oct 24, 2019 · 1 comment · Fixed by #4582
Closed
1 task done

Heading added below media for MAP #4403

ryanmccombe opened this issue Oct 24, 2019 · 1 comment · Fixed by #4582
Assignees
Labels
MAP ws-media World Service Media

Comments

@ryanmccombe
Copy link
Contributor

ryanmccombe commented Oct 24, 2019

Is your feature request related to a problem? Please describe.
The headline transformer always adds the heading to the start of the blocks

Screen Shot 2019-10-24 at 11 32 40

For MAPs, we want the media to be first

Describe the solution you'd like
Update the transformer to prevent it from adding a heading above the media player if the page is a MAP

It can add the heading below instead

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@ryanmccombe ryanmccombe added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-media World Service Media MAP labels Oct 24, 2019
@ryanmccombe ryanmccombe added this to the [WSM] Basic MAP Page milestone Oct 24, 2019
@pjlee11
Copy link

pjlee11 commented Oct 24, 2019

@ryanmccombe there are a11y requirements we should evaluate before just moving the headline below the AV player. I believe @greenc05 has been looking into this recently...

Update: #4150 has details on the investigation

@pharingee pharingee removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Oct 28, 2019
@aeroplanejane aeroplanejane added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Oct 31, 2019
@pjlee11 pjlee11 removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Nov 6, 2019
@pjlee11 pjlee11 self-assigned this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAP ws-media World Service Media
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants