Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromatic QA checks of RTL variants of stories #4373

Closed
jroebu14 opened this issue Oct 23, 2019 · 0 comments
Closed

Chromatic QA checks of RTL variants of stories #4373

jroebu14 opened this issue Oct 23, 2019 · 0 comments
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.

Comments

@jroebu14
Copy link

jroebu14 commented Oct 23, 2019

Is your feature request related to a problem? Please describe.
Currently, Chromatic QA checks just the default service news in Storybook.

Describe the solution you'd like
We should add RTL variants of default or good example stories. To do this we can use this functionality when it is merged and deployed BBC-archive/psammead#2453

Testing notes
QA's thoughts as to which stories to create the RTL variants for would be appreciated. QA could approve the new ChromaticQA screenshots.

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

Additional context
Add any other context or screenshots about the feature request here.

@jroebu14 jroebu14 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. simorgh-core-stream labels Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test.
Projects
None yet
Development

No branches or pull requests

2 participants