Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Alsos icons missing padding on RTL sites #3419

Closed
1 task
jamesbrumpton opened this issue Aug 27, 2019 · 0 comments · Fixed by BBC-archive/psammead#1923
Closed
1 task

Index Alsos icons missing padding on RTL sites #3419

jamesbrumpton opened this issue Aug 27, 2019 · 0 comments · Fixed by BBC-archive/psammead#1923
Assignees
Labels
bug Something isn't working

Comments

@jamesbrumpton
Copy link
Contributor

jamesbrumpton commented Aug 27, 2019

Describe the bug
The Index Alsos icons are missing padding on RTL sites and sit too close the text on-screen.

To Reproduce
Steps to reproduce the behavior:

  1. Check your fixture data includes cpsType: "Media" || mediaType: "Video" in the second or third story. (If not, snippet included in the base of this description.)
  2. Go to localhost.bbc.com:7080/arabic
  3. Adjust screen width to be less than 585px
  4. Observe the second and third story

Expected behavior
If the second and/or third story are media pages they should have icons displaying that. The icons will be to the left (on LTR) and right (on RTL) with enough padding between the text and the icon.

Screenshots
If applicable, add screenshots to help explain your problem.

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
image
RTL Example

image
LTR Example

Snippet

                "headlines": {
                  "headline": "السودان: الحديد والنار... وثائقي جديد"
                },
                "locators": {
                  "assetUri": "/arabic/media-48934531",
                  "cpsUrn": "urn:bbc:content:assetUri:/arabic/media-48934531"
                },
                "summary": "صانع الأفلام نمق خونشاو رافق دكتورة سودانية تدعى نمارق في الخرطوم بداخل الاعتصام قبل فضه، وسافر معها إلى مدينتها عطبرة، حيث أندلعت شعلة الاحتجاجات في ديسمبر/كانون الأول.",
                "timestamp": 1562744116000,
                "cpsType": "MAP",
                "mediaType": "Video",
                "id": "urn:bbc:ares::asset:arabic/media-48934531",
                "type": "cps"
              },
              {
                "headlines": {
                  "headline": "شباب السودان: \"النصر سيكون لنا\""
                },
                "locators": {
                  "assetUri": "/arabic/media-48839628",
                  "cpsUrn": "urn:bbc:content:assetUri:/arabic/media-48839628"
                },
                "summary": "قاد الشباب السوداني المظاهرات السلمية التي أطاحت بـ30 عاما من حكم عمر البشير. وبعد فترة هدوء تلت فض اعتصام القيادة العامة، عاد الشباب للمطالبة بالتغيير.",
                "timestamp": 1562063635000,
                "cpsType": "MAP",
                "mediaType": "Audio",
                "id": "urn:bbc:ares::asset:arabic/media-48839628",
                "type": "cps"
              }```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants