Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wait-on" dependency hangs #1109

Closed
1 task done
ChrisBAshton opened this issue Dec 21, 2018 · 0 comments
Closed
1 task done

"wait-on" dependency hangs #1109

ChrisBAshton opened this issue Dec 21, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ChrisBAshton
Copy link
Contributor

Describe the bug
We currently cannot run the test:ampValidate task as it relies on starting up a server and then running the AMP validator.

A dependency - wait-on - should handle listening for the server startup and then triggering the validator. But it currently hangs.

If we remove wait-on altogether, the validator is called too soon and the page can't be validated.

Arises from #1101.

To Reproduce
Steps to reproduce the behavior:

  1. Run npm run test:ampValidate, which calls wait-on http://localhost:7080
  2. Observe that the terminal hangs, and that amphtml-validator doesn't execure

Expected behavior
When the server has started, amphtml-validator should be triggered, and, pass or fail, the process should exit.

  • Initially labelled with "bug"
@ChrisBAshton ChrisBAshton added the bug Something isn't working label Dec 21, 2018
@sareh sareh mentioned this issue Dec 21, 2018
4 tasks
@bcmn bcmn self-assigned this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants