We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug We currently cannot run the test:ampValidate task as it relies on starting up a server and then running the AMP validator.
test:ampValidate
A dependency - wait-on - should handle listening for the server startup and then triggering the validator. But it currently hangs.
wait-on
If we remove wait-on altogether, the validator is called too soon and the page can't be validated.
Arises from #1101.
To Reproduce Steps to reproduce the behavior:
npm run test:ampValidate
wait-on http://localhost:7080
amphtml-validator
Expected behavior When the server has started, amphtml-validator should be triggered, and, pass or fail, the process should exit.
The text was updated successfully, but these errors were encountered:
bcmn
No branches or pull requests
Describe the bug
We currently cannot run the
test:ampValidate
task as it relies on starting up a server and then running the AMP validator.A dependency -
wait-on
- should handle listening for the server startup and then triggering the validator. But it currently hangs.If we remove
wait-on
altogether, the validator is called too soon and the page can't be validated.Arises from #1101.
To Reproduce
Steps to reproduce the behavior:
npm run test:ampValidate
, which callswait-on http://localhost:7080
amphtml-validator
doesn't execureExpected behavior
When the server has started,
amphtml-validator
should be triggered, and, pass or fail, the process should exit.The text was updated successfully, but these errors were encountered: