Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test our move from @BBC-News to @bbc #1063

Closed
10 of 12 tasks
ChrisBAshton opened this issue Dec 11, 2018 · 5 comments
Closed
10 of 12 tasks

Test our move from @BBC-News to @bbc #1063

ChrisBAshton opened this issue Dec 11, 2018 · 5 comments
Assignees
@ChrisBAshton
Labels
investigation question Further information is requested

Comments

@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Dec 11, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.
We should move Psammead and Simorgh to the @bbc org, from @BBC-News.

(Note that we should be absolutely sure @bbc supports everything we need, and we should try as much as we can with a dummy repo first.)

Advantages of moving to @bbc:

  • We can have one project board (preliminary investigation shows that the private repo issues would appear as "You can't see this card" for public)
  • More shareable in the world of OPR (we might have to do it anyway)
  • More cohesive for new joiners and anyone in the BBC searching for our repos / infrastructure

Disadvantages:

  • Having to port across CodeClimate, Greenkeeper, Slack, CodeClimate velocity integrations. There's also a question of how much we're able to put onto @bbc
  • Having to update Jenkins, Snyk, CodeClimate, Slack web hooks
  • Up front effort of moving repos, recreating labels (perhaps this will be automated by GitHub? 🤔) and getting the team back up to speed
  • The Psammead infrastructure repo is probably going away, so the only benefit of the joined up Project view would be the Simorgh infrastructure repo

Team discussion.

Hypothetical acceptance criteria

  • Pull request check from CodeClimate
  • Pull request check from Snyk
  • Pull request check from Jenkins CI
  • Pull request check from Travis
  • Slack notifications from GitHub on issue open/close and on PR merge
  • Slack notifications on Storybook deployment
  • Slack notifications on Jenkins build fail
  • Slack notifications on Travis build fail
  • Infrastructure pipeline points to the correct place
  • Greenkeeper continues to open PRs (how do we test this?)
  • Psammead storybook deployment still works Add storybook to jenkinsfile BBC-archive/psammead#194 (review)
  • Psammead npm publish still works (generating otp, etc)
@ChrisBAshton ChrisBAshton added question Further information is requested investigation Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Dec 11, 2018
@ChrisBAshton ChrisBAshton changed the title Move to @bbc Discuss moving to @bbc Dec 11, 2018
@sareh sareh mentioned this issue Dec 13, 2018
Merged
3 tasks
@ChrisBAshton ChrisBAshton removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Jan 9, 2019
@ChrisBAshton ChrisBAshton reopened this Jan 9, 2019
@pjlee11
Copy link

pjlee11 commented Jan 9, 2019 •
edited
Loading

Add to checklist: Slack notification when Jenkins successfully deploys to live

Edit: That handled in the Jenkinsfile and if unrelated to the home of the repo 🤦‍♂️

@ChrisBAshton
Copy link
Contributor Author

Blocked on BBC-archive/psammead#241

(That will tell us if Psammead storybook publishing & slack notification is still working)

@ChrisBAshton ChrisBAshton added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 9, 2019
@ChrisBAshton
Copy link
Contributor Author

Have raised #1149 to fix the CodeClimate diff/coverage checker.

@ChrisBAshton ChrisBAshton changed the title Discuss moving to @bbc Test our move from @BBC-News to @bbc Jan 10, 2019
@ChrisBAshton ChrisBAshton removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 10, 2019
@ChrisBAshton
Copy link
Contributor Author

Storybook was updated 🎉

But no announcement in Slack

@ChrisBAshton
Copy link
Contributor Author

Believe we've now fixed the Storybook announcement on Slack, but haven't tested it yet. Happy to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisBAshton ChrisBAshton

Labels
investigation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisBAshton @pjlee11