This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Brand should have max width of 80rem #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bopchy
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
dr3
reviewed
Jun 18, 2019
| @@ -19,6 +22,11 @@ const PADDING_AROUND_SVG_BELOW_600PX = 32; | |||
| const conditionallyRenderHeight = (svgHeight, padding) => | |||
| svgHeight ? `height: ${(svgHeight + padding) / 16}rem` : ''; | |||
|
|
|||
| const SvgWrapper = styled.div` | |||
| max-width: ${GEL_GROUP_4_SCREEN_WIDTH_MAX}; | |||
There was a problem hiding this comment.
Even though they are the same value 🙈 Can you use GEL_GROUP_5_SCREEN_WIDTH_MIN here instead please :P Its what we used before :)
dr3
reviewed
Jun 18, 2019
| @@ -100,18 +108,20 @@ const StyledBrand = ({ | |||
| <Fragment> | |||
There was a problem hiding this comment.
Also, this doesnt work when the svg is a link weirdly :P May need to move the wrapper up a bit
added 3 commits
June 19, 2019 11:20
j-pendlebury
suggested changes
Jun 19, 2019
j-pendlebury
approved these changes
Jun 19, 2019
dr3
approved these changes
Jun 19, 2019
|
Looks good, this is ready for merge! |
…d-have-max-width-80rem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #645
Overall change: Update brand to have a max-width of 80rem.
Code changes: