This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add transparent borders on brand component #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ws-home
ghost
self-assigned this
ghost
marked this pull request as ready for review
andrew-nowak
suggested changes
Jun 18, 2019
Co-Authored-By: Andrew Nowak <10963046+aacn500@users.noreply.github.com>
Co-Authored-By: Andrew Nowak <10963046+aacn500@users.noreply.github.com>
dr3
approved these changes
Jun 18, 2019
greenc05
reviewed
Jun 19, 2019
|
This PR has now conflicts. |
|
Tom and I have checked over and all looks good, thanks |
|
Looks good to me, this is ready for merge.
|
amywalkerdev
added a commit
that referenced
this pull request
Jun 20, 2019
Add transparent borders on brand component
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #646
Overall change: Add transparent borders controlled via props to make the start/end of
Brandcomponent clear in high contrast mode.Code changes:
borderBottomandborderTop