This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update stories to use new inputProvider #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
marked this pull request as ready for review
ghost
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
dr3
suggested changes
May 7, 2019
dr3
suggested changes
May 7, 2019
dr3
suggested changes
May 8, 2019
There was a problem hiding this comment.
We need to do Paragraph too, https://github.com/bbc/psammead/blob/latest/packages/components/psammead-paragraph/src/index.stories.jsx#L13
dr3
previously approved these changes
May 8, 2019
ghost
changed the title
DenisHdz
reviewed
May 9, 2019
DenisHdz
approved these changes
May 9, 2019
|
LGTM. Happy for this to be merged. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #497
Resolves #495
Overall change: Update stories that use
inputProviderto use version2.0.0Code changes:
Caption,SubHeading,SitewideLinks,InlineLink,VisuallyHiddenTextandStoryPromostories to use@bbc/psammead-storybook-helpers@2.0.0