Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Adds Noto Serif Bengali font #4547

Merged
merged 37 commits into from
Sep 16, 2021
Merged

Adds Noto Serif Bengali font #4547

merged 37 commits into from
Sep 16, 2021

Conversation

pvaliani
Copy link
Contributor

@pvaliani pvaliani commented Sep 2, 2021 •
edited
Loading

Resolves bbc/simorgh#9366

Overall change:

  • Adds Noto Serif Bengali font

Code changes:

  • Adds Noto Serif Bengali font
  • Updates Typography font sizes
  • Bumps psammead styles and gel foundation versions
  • (BBC contributors only) This PR follows the repository use guidelines
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4547

@pvaliani pvaliani marked this pull request as ready for review September 2, 2021 15:49
DarioR01
DarioR01 suggested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@DarioR01 DarioR01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small problems with bumps. And I am not sure where you are getting the values for groupB and groupD for imperial foolscap and royal

packages/components/psammead-story-promo-list/CHANGELOG.md Outdated Show resolved Hide resolved
packages/components/psammead-story-promo-list/package.json Show resolved Hide resolved
packages/utilities/psammead-storybook-helpers/CHANGELOG.md Show resolved Hide resolved
packages/utilities/gel-foundations/src/scripts/bengali-noto-serif.js Show resolved Hide resolved
DarioR01
DarioR01 previously approved these changes Sep 16, 2021
View reviewed changes
MuhammadAHussain
MuhammadAHussain approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@MuhammadAHussain MuhammadAHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

DarioR01
DarioR01 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@DarioR01 DarioR01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, everything looks great, nice job!!!

@HarveyPeachey HarveyPeachey merged commit 13ab3c9 into latest Sep 16, 2021
@HarveyPeachey HarveyPeachey deleted the add-noto-serif-bengali branch September 16, 2021 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HarveyPeachey HarveyPeachey HarveyPeachey left review comments

@nicola-d-bbc nicola-d-bbc nicola-d-bbc left review comments

@andrewscfc andrewscfc andrewscfc approved these changes

@MuhammadAHussain MuhammadAHussain MuhammadAHussain approved these changes

@DarioR01 DarioR01 DarioR01 approved these changes

Assignees

@HarveyPeachey HarveyPeachey

@nicola-d-bbc nicola-d-bbc

@pvaliani pvaliani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fonts on the Bengali service
6 participants
@pvaliani @HarveyPeachey @andrewscfc @MuhammadAHussain @nicola-d-bbc @DarioR01