This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
add data-e2e attributes for e2e tests #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4436 |
jroebu14
force-pushed
the
data-e2e-attrs
branch
from
d22a6b2 to
f77ff45
Compare
jroebu14
added
the
cross-team
andrewscfc
approved these changes
Mar 16, 2021
simonsinclair
approved these changes
Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change:
Adds
data-e2eattributes to elements so we can assert these elements are in/out of the DOM in our Cypress e2e tests.We currently select elements in the DOM using class name queries however class names have changed with the Emotion 11 upgrade - class names no longer take the name of the styled component. Class name selectors in tests is generally not recommended anyway.
Code changes: