-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
Checkout your storybook preview here http://psammead-preview.tools.bbc.co.uk/4368 |
Nice work Jonathan. Does this still allow us to publish packages publicly individually to NPM as we do now. I thought the impression that by default yarn wanted packages to be private? |
I thought it was just the root package that had to be private |
You are right, just read up on it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, really excited to see if this facilitates cross repo dev 🤞 Just a few questions around the change scanner but not blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great. Thanks for this @jroebu14
Bump package versions for psammead, psammead-amp-geo, psammead-brand, psammead-bulleted-list, psammead-bulletin, psammead-byline, psammead-caption, psammead-consent-banner, psammead-content-anchor, psammead-copyright, psammead-embed-error, psammead-episode-list, psammead-figure, psammead-grid, psammead-heading-index, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-live-label, psammead-media-indicator, psammead-media-player, psammead-most-read, psammead-navigation, psammead-oembed, psammead-paragraph, psammead-play-button, psammead-podcast-promo, psammead-radio-schedule, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-social-embed, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-topic-tags, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, moment-timezone-include, psammead-assets, psammead-calendars, psammead-detokeniser, psammead-locales, psammead-rich-text-transforms, psammead-storybook-helpers, psammead-styles, psammead-test-helpers, web-vitals
Updates changelogs for psammead, psammead-amp-geo, psammead-brand, psammead-bulleted-list, psammead-bulletin, psammead-byline, psammead-caption, psammead-consent-banner, psammead-content-anchor, psammead-copyright, psammead-embed-error, psammead-episode-list, psammead-figure, psammead-grid, psammead-heading-index, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-live-label, psammead-media-indicator, psammead-media-player, psammead-most-read, psammead-navigation, psammead-oembed, psammead-paragraph, psammead-play-button, psammead-podcast-promo, psammead-radio-schedule, psammead-script-link, psammead-section-label, psammead-sitewide-links, psammead-social-embed, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-topic-tags, psammead-useful-links, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, moment-timezone-include, psammead-assets, psammead-calendars, psammead-detokeniser, psammead-locales, psammead-rich-text-transforms, psammead-storybook-helpers, psammead-styles, psammead-test-helpers, web-vitals
Resolves #4332
Overall change:
Adds Yarn Workspaces.
Update
Talos depends on Lerna exec so not cannot be removed unless we find a replacement for either Lerna or Talos.
Code changes:
ci:packages
script:node_modules
install:packages
script:yarn install
installs all package's dependencies in a single pass in the rootnode_modules
and links cross-dependencies by defaultlerna exec
withyarn workspaces run
yarn workspaces run
is native to Yarn and does the same thing aslerna exec
moment-timezone-include
package to use commonjs modules. This is because thepostinstall
script in this package'spackage.json
(which runs a node script in the build directory) ran before thepostinstall
script in the rootpackage.json
(which transpiles code and generates the build directories) and attempts to run a script that doesn't yet exist. Using commonjs modules means we don't need to transpile the code before running the node script.changeScanner
script to check that the rootyarn.lock
has been updated if any package's dependencies have been updated