Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Alphabetise text variants #432

Merged
merged 4 commits into from
Apr 12, 2019
Merged

Conversation

andrew-nowak
Copy link
Contributor

Resolves #426

Overall change: Updates the list of text variants in psammead-storybook-helpers to be sorted in alphabetical order by language name.

Code changes:

  • Sorted the list of text variants.

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@andrew-nowak andrew-nowak added the ws-home Tasks for the WS Home Team label Apr 10, 2019
@andrew-nowak andrew-nowak self-assigned this Apr 10, 2019
@andrew-nowak andrew-nowak marked this pull request as ready for review April 10, 2019 15:58
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@jamesbrumpton
Copy link
Contributor

LGTM. Happy for this to be merged.

@andrew-nowak andrew-nowak merged commit d921248 into latest Apr 12, 2019
@andrew-nowak andrew-nowak deleted the storybook-inputs-alphabetise branch April 12, 2019 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alphabetise languages in inputProvider
4 participants