Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add custom scripts propTypes in gel-foundations #431

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Add custom scripts propTypes in gel-foundations #431

merged 3 commits into from
Apr 11, 2019

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Apr 10, 2019 •
edited
Loading

Resolves #425

Overall change:
Following the discussion in this PR we decided to add the custom propTypes definition for the scripts inside the gel-foundations package.

Code changes:

  • Add index, groups and sizes files containing the current shape of the scripts
  • Load propTypes dynamically using threesaking
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Apr 10, 2019
@DenisHdz DenisHdz self-assigned this Apr 10, 2019
@DenisHdz DenisHdz added blocked This issue should not be worked on until another internal issue is completed - see desc for details and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Apr 10, 2019
@DenisHdz DenisHdz mentioned this pull request Apr 10, 2019
Merged
3 tasks
j-pendlebury
j-pendlebury suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a version bump and an update to the CHANGELOG but otherwise looks good to me

dr3
dr3 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What jamie said ^ 🙈

dr3
dr3 suggested changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@DenisHdz
Copy link
Contributor Author

Done 🚀

dr3
dr3 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, really nice layout

pjlee11
pjlee11 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@pjlee11 pjlee11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 😎

j-pendlebury
j-pendlebury reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er... out of date with latest 🙈

@david-boydell
Copy link

Agreed this can be merged, no observable output and no effect on the user experience

@DenisHdz DenisHdz merged commit cbe452b into latest Apr 11, 2019
@andrew-nowak andrew-nowak deleted the add-proptypes-in-gel-foundations branch April 16, 2019 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@pjlee11 pjlee11 pjlee11 approved these changes

@dr3 dr3 dr3 approved these changes

Assignees

@DenisHdz DenisHdz

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DenisHdz @david-boydell @pjlee11 @dr3 @j-pendlebury @amywalkerdev