This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Add new typography method in Headings component #421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr3
reviewed
Apr 8, 2019
`; | ||
|
||
Headline.defaultProps = { | ||
script: objectOf(object).required, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have raised #425 to improve this
dr3
previously approved these changes
Apr 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dr3
suggested changes
Apr 8, 2019
Conflicts fixed 🛠 |
j-pendlebury
approved these changes
Apr 9, 2019
dr3
approved these changes
Apr 9, 2019
LGTM. Puedes unirlo. |
…to headings-support-scripts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #343
Overall change:
Add support to allow the
Headings
component to use Typography Type Sizes for different scriptsCode changes:
propTypes
to require ascript
propGEL_CANON
andGEL_TRAFALGAR
importsgetCanon
andgetTrafalgar
methods which make use of the newgetTypeSizes()
method to get the appropriate GEL Type Sizes for the component.latin.js
script with the default typography GEL Types Sizes in the stories and unit test