Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add language variants knob to Headline and SubHeading #418

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Add language variants knob to Headline and SubHeading #418

merged 4 commits into from
Apr 8, 2019

Conversation

andrew-nowak
Copy link
Contributor

Relates to #331, #370

Overall change: Adds the support for examining Psammead components' behaviour
in the different language services

Code changes:

  • Updates stories for the psammead-headings (Headline and SubHeading) components to use the psammead-storybook-helpers utility inputProvider
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@andrew-nowak andrew-nowak added the ws-home Tasks for the WS Home Team label Apr 5, 2019
@andrew-nowak andrew-nowak self-assigned this Apr 5, 2019
dr3
dr3 previously approved these changes Apr 8, 2019
View reviewed changes
amywalkerdev
amywalkerdev approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@amywalkerdev amywalkerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamesbrumpton
Copy link
Contributor

LGTM. Happy for this to be merged.

@amywalkerdev amywalkerdev merged commit f91cf11 into latest Apr 8, 2019
@amywalkerdev amywalkerdev deleted the lvk-headings branch April 8, 2019 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 approved these changes

@amywalkerdev amywalkerdev amywalkerdev approved these changes

Assignees

@andrew-nowak andrew-nowak

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-nowak @jamesbrumpton @dr3 @amywalkerdev