This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
H2 styling tweaks round 2 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr3
reviewed
Apr 2, 2019
|
In firefox (quantum, 66.0.2 (64-bit)) I'm getting 0 padding-bottom and this when I inspect the element: |
dr3
reviewed
Apr 3, 2019
dr3
suggested changes
Apr 3, 2019
Co-Authored-By: pjlee11 <phil.lee.ext@bbc.co.uk>
pjlee11
commented
Apr 3, 2019
|
@eleanombre good spot, |
dr3
suggested changes
Apr 3, 2019
twinlensreflex
previously approved these changes
Apr 3, 2019
added 2 commits
April 9, 2019 17:34
…nto h2-styling-tweaks-round-2
dr3
previously approved these changes
Apr 9, 2019
sareh
previously approved these changes
Apr 9, 2019
|
LGTM. Happy for this to be merged. |
dr3
approved these changes
Apr 11, 2019
j-pendlebury
approved these changes
Apr 11, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #404
Follows up #406
Following the completion of #404 UX and dev sat together and reviewed the initial issue against the Zeplin design specs and found inconsistencies, this PR fixes those inconsistencies.
Overall change: Increases the padding-bottom of the H2 to be 24px and changes the media query to be 600px and above.
Code changes:
padding-bottomof the<h2>has been increased from 16px to 24px on all viewports<h2>has been increased from the incorrect 400px to 600px[ ] I have assigned myself to this PR and the corresponding issues