This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Remove wrapping div from Brand's skip-link #4110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsinclair
added
bug
simonsinclair
added
the
cross-team
simonsinclair
changed the title
simonsinclair
changed the title
simonsinclair
changed the title
simonsinclair
commented
Dec 10, 2020
joshcoventry
approved these changes
Dec 10, 2020
1 task
chris-hinds
approved these changes
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves bbc/simorgh#8511.
Overall change:
Adding a wrapping
divto SkipLink appears to affect how it's positioned when it's hidden. After investigation, we think this causes the regression seen in the issue above. This PR reverts the small change made in #3986 27 days ago.Code changes:
divfrom Brand's skip-link.Automated jest tests added (for new features) or updated (for existing features)This PR requires manual testing