This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
fix firefox not allowing fullscreen #3990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroebu14
changed the title
|
Tested this on Storybook. The fullscreen button now works in Firefox 77 for all the Media Player variations in storybook. |
rebeccamcginn
approved these changes
Nov 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall change:
Fixes media player not being able to go into full screen mode in Firefox < 77.
Code changes:
fullscreenfromallowattribute on iframe because ifallow="fullscreen"andallowfullscreenare both present on an iframe element, then the more restrictiveallowlistofallow="fullscreen"will be used which didn't work in FF.