Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update Component Dependencies #398

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Update Component Dependencies #398

merged 4 commits into from
Mar 28, 2019

Conversation

sareh
Copy link
Contributor

@sareh sareh commented Mar 27, 2019

Overall change: Update to use latest dependencies psammead-styles@0.3.2 & gel-foundations@0.3.0

Visually, there should be no changes.

gel-foundations@0.3.0 changed the media query values to be rem instead of em.

Code changes:

  • psammead-brand & psammead-figure - updates gel-foundations from v0.1.4 to 0.2.4 (Typography is changed from em to rem, but these components don't have visible text, so there are no visible changes)
  • psammead-brand updates psammead-styles from 0.1.6 to 0.3.2 (This adds new colours and fonts, but these should not have any visual change.)
  • psammead-brand, psammead-copyright, psammead-paragraph, psammead-headings, psammead-sitewide-links psammead-figure - updates gel-foundations from v0.2.4 to 0.3.0 (This updates the media query values from em to rem. )

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@sareh sareh self-assigned this Mar 27, 2019
@sareh sareh requested a review from a team as a code owner March 27, 2019 09:43
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Tested using storybook, looks great, inc sitewidelinks fix
no clue why snyk isnt happy though

@ChrisBAshton
Copy link
Contributor

Screen Shot 2019-03-27 at 11 38 03

Think it just had a temporary outage ^

@dr3 dr3 mentioned this pull request Mar 27, 2019
3 tasks
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - and thanks for adding prettier-ignore to all the tables.

Should do a UX review next 👍

@jamesbrumpton
Copy link
Contributor

👍

@ChrisBAshton ChrisBAshton merged commit 748f304 into latest Mar 28, 2019
@ChrisBAshton ChrisBAshton deleted the update-styles branch March 28, 2019 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants