Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Remove alpha tag from psammead-timestamp-container #3935

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Remove alpha tag from psammead-timestamp-container #3935

merged 2 commits into from
Oct 19, 2020

Conversation

RichardPK
Copy link
Contributor

Resolves #NUMBER

Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@RichardPK RichardPK self-assigned this Oct 19, 2020
simonsinclair
simonsinclair approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@simonsinclair simonsinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

packages/containers/psammead-timestamp-container/CHANGELOG.md Outdated Show resolved Hide resolved
@RichardPK
Copy link
Contributor Author

💩

ryanmccombe
ryanmccombe approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@ryanmccombe ryanmccombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

@RichardPK RichardPK merged commit 20f4789 into latest Oct 19, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Oct 19, 2020
Merged
@simonsinclair simonsinclair deleted the fix-timestamp-container-version branch December 3, 2020 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonsinclair simonsinclair simonsinclair approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

Assignees

@RichardPK RichardPK

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardPK @simonsinclair @ryanmccombe