This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
[Emotion lvl 2] Migrated section-label titles.jsx & story-promo-list #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardPK
commented
Oct 16, 2020
RichardPK
commented
Oct 16, 2020
| const FlexTextRow = styled(FlexRow).attrs({ | ||
| const FlexTextRow = styled(FlexRow)``; | ||
|
|
||
| FlexTextRow.defaultProps = { |
There was a problem hiding this comment.
What do you think - should this just be passed into the FlexTextRow component on ln 165, rather than using defaultProps?
I have used this strategy for the aria- values that were previously being passed in as attrs to IndexLinkCta and SectionLabelLink
There was a problem hiding this comment.
Yeah, I don't think this styled component FlexTextRow is actually needed, because there are no styles attached to it. FlexRow could be used directly with role="text" passed to it.
There was a problem hiding this comment.
I've pushed these changes.
There was a problem hiding this comment.
Awesome thank you Simon!
…thub.com:bbc/psammead into emotion-migration-story-promo-list-section-label
RichardPK
commented
Oct 16, 2020
ryanmccombe
approved these changes
Oct 16, 2020
simonsinclair
added
the
cross-team
simonsinclair
added
the
technical-work
simonsinclair
approved these changes
Oct 16, 2020
simonsinclair
deleted the
emotion-migration-story-promo-list-section-label
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes: