This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
[Emotion L4] Media Player #3902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/components/psammead-media-player/CHANGELOG.md # packages/components/psammead-media-player/package-lock.json # packages/components/psammead-media-player/package.json # packages/components/psammead-media-player/src/Placeholder/__snapshots__/index.test.jsx.snap # packages/components/psammead-media-player/src/__snapshots__/index.test.jsx.snap
ryanmccombe
changed the title
| @@ -538,31 +769,6 @@ exports[`Media Player: Placeholder should render an audio placeholder without du | |||
|
|
|||
| exports[`Media Player: Placeholder should render no-js styles when noJsClassName prop is used 1`] = ` | |||
| .emotion-6 { | |||
| background-color: #222222; | |||
There was a problem hiding this comment.
Hmm, potential loss of styles from here? Seems to be no-js related.
| @@ -472,32 +701,13 @@ exports[`Media Player: Canonical Entry renders the audio skin 1`] = ` | |||
| `; | |||
|
|
|||
| exports[`Media Player: Canonical Entry renders with no-js styles when noJsClassName prop is used 1`] = ` | |||
| .emotion-6 { | |||
| background-color: #222222; | |||
There was a problem hiding this comment.
The same block here.
simonsinclair
added
cross-team
RichardPK
approved these changes
Oct 16, 2020
simonsinclair
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change: A very high-level summary of easily-reproducible changes that can be understood by non-devs.
Code changes: