Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Boosts Headline padding to 40px (32px on mobile) #381

Merged
merged 11 commits into from
Mar 29, 2019
Merged

Boosts Headline padding to 40px (32px on mobile) #381

merged 11 commits into from
Mar 29, 2019

Conversation

ChrisBAshton
Copy link
Contributor

@ChrisBAshton ChrisBAshton commented Mar 22, 2019 •
edited
Loading

Resolves #375

Overall change: Changes Headline padding according to the designs.

Code changes:

  • Increases padding to 40px for Smartphone and up. 32px for smaller.
  • Updates snapshot tests
  • Adds changelog and bumps version number
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ChrisBAshton ChrisBAshton self-assigned this Mar 22, 2019
@ChrisBAshton ChrisBAshton requested a review from a team as a code owner March 22, 2019 14:01
twinlensreflex
twinlensreflex previously approved these changes Mar 22, 2019
View reviewed changes
dr3
dr3 suggested changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a package bump and changelog

@ChrisBAshton ChrisBAshton requested a review from dr3 March 26, 2019 13:53
Drew McMillan and others added 2 commits March 26, 2019 15:03
@ChrisBAshton
fixes changelog description
3ec7b1e 
Co-Authored-By: ChrisBAshton <ChrisBAshton@users.noreply.github.com>
@ChrisBAshton
makes this a major change 0.4.0
1b1eb0f
@ChrisBAshton ChrisBAshton requested a review from dr3 March 26, 2019 15:17
Drew McMillan and others added 2 commits March 26, 2019 16:14
@ChrisBAshton
makes css cleaner
775659e 
Co-Authored-By: ChrisBAshton <ChrisBAshton@users.noreply.github.com>
@ChrisBAshton
Merge branch 'latest' into headline
336e55e
@ChrisBAshton ChrisBAshton requested a review from dr3 March 26, 2019 16:14
dr3
dr3 previously approved these changes Mar 26, 2019
View reviewed changes
pjlee11
pjlee11 previously approved these changes Mar 26, 2019
View reviewed changes
@pjlee11 pjlee11 mentioned this pull request Mar 27, 2019
Closed
3 tasks
@jamesbrumpton
Copy link
Contributor

👍

@ChrisBAshton ChrisBAshton dismissed stale reviews from pjlee11 and dr3 via 0c8734c March 28, 2019 14:41
@ChrisBAshton ChrisBAshton mentioned this pull request Mar 28, 2019
Merged
4 tasks
@ChrisBAshton ChrisBAshton merged commit 1d6febf into latest Mar 29, 2019
@ChrisBAshton ChrisBAshton deleted the headline branch March 29, 2019 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pjlee11 pjlee11 pjlee11 approved these changes

@dr3 dr3 dr3 approved these changes

@twinlensreflex twinlensreflex twinlensreflex left review comments

Assignees

@ChrisBAshton ChrisBAshton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisBAshton @jamesbrumpton @pjlee11 @dr3 @twinlensreflex