Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create Optimo Base service #3771

Merged

Conversation

rossgaskell
Copy link

@rossgaskell rossgaskell commented Sep 18, 2020

Resolves #3808

Overall change: Adds Base service for Optimo Renditions

Code changes:

  • Inherits from Latin Reith font styles but excludes Reith Serif

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

Copy link
Contributor

@simonsinclair simonsinclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@simonsinclair simonsinclair added the cross-team For visibility for both World Service teams (Engage & Media) label Sep 30, 2020
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossgaskell Looks good, just needs to bump the package.json, package-lock.json and update the CHANGELOG for these packages.

@chris-hinds
Copy link
Contributor

@rossgaskell we also have some issues with running forks against our internal Jenkins setup. I'll ensure you have right access to this repo, could you make sure branch/PR is created within the main Psammead repo so that the Jenkins pipeline will run.

We need to find a reliable way for having our pipeline run against forks.

@rossgaskell
Copy link
Author

@rossgaskell Looks good, just needs to bump the package.json, package-lock.json and update the CHANGELOG for these packages.

Is there an automated way of doing this @DenisHdz or is it a manual process?

@rossgaskell
Copy link
Author

@rossgaskell we also have some issues with running forks against our internal Jenkins setup. I'll ensure you have right access to this repo, could you make sure branch/PR is created within the main Psammead repo so that the Jenkins pipeline will run.

We need to find a reliable way for having our pipeline run against forks.

No worries @chris-hinds, will do

@DenisHdz
Copy link
Contributor

@rossgaskell Looks good, just needs to bump the package.json, package-lock.json and update the CHANGELOG for these packages.

Is there an automated way of doing this @DenisHdz or is it a manual process?

Unfortunately not, you have to change the package version and add a new record to the log manually.

Ross Gaskell added 3 commits October 1, 2020 08:46
Bump package versions for psammead-storybook-helpers, psammead-styles
Updates changelogs for psammead-storybook-helpers, psammead-styles
@rossgaskell rossgaskell merged commit 2887a07 into BBC-archive:latest Oct 1, 2020
@rossgaskell rossgaskell deleted the create-optimo-base-service branch October 1, 2020 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cross-team For visibility for both World Service teams (Engage & Media)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Optimo Base service
4 participants