This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add story for Media Message component & remove border #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardPK
added
a11y
karinathomasbbc
approved these changes
Aug 14, 2020
rebeccamcginn
approved these changes
Aug 18, 2020
greenc05
reviewed
Aug 18, 2020
| @@ -11,6 +14,12 @@ const withDuration = { | |||
| datetime: 'PT2M30S', | |||
| }; | |||
|
|
|||
| const StyledMessageContainer = styled.div` | |||
| padding-top: 56.25%; | |||
There was a problem hiding this comment.
Just wondering what 56.25% is for? This value seems unsual? Did we use this before this PR?
There was a problem hiding this comment.
It's a means of applying a 16:9 ratio to the container's padding. Where 16 is the width, 56.26% of that (9) is the height.
We use it in Simorgh as a means of pushing the other page content below the player - I'm just mocking that in the story to emulate the styling.
Frankly it seems like a mad way to manage layout but I'm sure there's good reason for doing it.
There was a problem hiding this comment.
Intersting, ok thanks for the explanation @RichardPK
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3624
Overall change:
MediaMessagecomponent withservice&messageknobs.<strong>element within component