This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update Bengali inline link styling #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FK78 Have you got a screenshot of a rendered page showing the fix? Does this need a UX review? |
simonsinclair
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
The values check out. Nice work, Fahad. 👍
Let's be sure to get a UX review before merging.
I've just realised that before a UX review can happen, we need to merge this PR and then bump gel-foundations in the dependents (psammead-styles etc.).
N.B. Let's aim to get this merged as soon as possible, so we can verify the changes in a following Psammead PR.
Hey, as the stories we currently have rely on |
rhenshaw56
approved these changes
Jul 20, 2020
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3162
Overall change: Update Bengali inline link styling.
Code changes:
bodyCopyandlongPrimervalues inpackages/utilities/gel-foundations/src/scripts/bengali.js. This is done to accommodate the border bottom styling for inline links.