Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix paragraph prop-types #3592

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Fix paragraph prop-types #3592

merged 2 commits into from
Jul 10, 2020

Conversation

ryanmccombe
Copy link
Contributor

@ryanmccombe ryanmccombe commented Jul 10, 2020 •
edited
Loading

Overall change: Fix issue where prop types were defined twice.

Code changes:

  • Switch prop types for default props.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@ryanmccombe ryanmccombe self-assigned this Jul 10, 2020
@ryanmccombe ryanmccombe merged commit 3295df8 into latest Jul 10, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jul 10, 2020
Merged
@amywalkerdev amywalkerdev deleted the fix-paragraph-prop-types branch September 28, 2020 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@rebeccamcginn rebeccamcginn rebeccamcginn approved these changes

Assignees

@ryanmccombe ryanmccombe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmccombe @karinathomasbbc @rebeccamcginn