Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update radio time indicator styling #3559

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Update radio time indicator styling #3559

merged 4 commits into from
Jun 24, 2020

Conversation

rebeccamcginn
Copy link
Contributor

@rebeccamcginn rebeccamcginn commented Jun 24, 2020 •
edited
Loading

Related to #6881

Overall change: Removed overflow:hidden to fix current time indicator on OD Radio and Live Radio as they are being partially chopped off.

Code changes:

  • Removed overflow:hidden from StyledAudioContainer
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@rebeccamcginn rebeccamcginn added the ws-media The World Service media stream label Jun 24, 2020
@rebeccamcginn rebeccamcginn self-assigned this Jun 24, 2020
@rebeccamcginn rebeccamcginn changed the title Update radio styling Update radio time indicator styling Jun 24, 2020
@rebeccamcginn rebeccamcginn merged commit 7cd8d9a into latest Jun 24, 2020
@rebeccamcginn rebeccamcginn deleted the update_radio_styling branch June 24, 2020 14:04
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jun 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@RichardPK RichardPK RichardPK approved these changes

Assignees

@rebeccamcginn rebeccamcginn

Labels
ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebeccamcginn @ryanmccombe @RichardPK