This repository was archived by the owner on Aug 13, 2023. It is now read-only.
Remove white border from Program Card #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaLyubin
commented
Apr 7, 2020
j-pendlebury
approved these changes
Apr 7, 2020
1 task
|
Merging in, as it has been tested on Firefox high contrast mode. |
This was referenced Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change:
Duration button was not completely adjacent to Card Wrapper because of the 1px border. Border is now replaced with outline, so the duration button sticks to the program card while FireFox high contrast mode still maintains the borders visible.
Before:
After:
High Contrast mode in FireFox:
Code changes:
borderwithoutlineinCardWrapper.