Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Refactored Message component to support AV streams expired message #3060

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

rebeccamcginn
Copy link
Contributor

bbc/simorgh#4796

Overall change:
The MediaMessage component was created for non-JS scenarios. It has now been refactored for use in no-JS scenarios and in expired stream scenarios.

Code changes:

  • Renamed component Message
  • Export Message from psammead-media-player
  • Renamed noJSMessage prop to message

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@rebeccamcginn rebeccamcginn added the ws-media The World Service media stream label Feb 4, 2020
@rebeccamcginn rebeccamcginn self-assigned this Feb 4, 2020
@rebeccamcginn rebeccamcginn marked this pull request as ready for review February 4, 2020 17:51
Copy link
Contributor

@jroebu14 jroebu14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashing

Copy link
Contributor

@ryanmccombe ryanmccombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rebeccamcginn rebeccamcginn merged commit c0a4e5b into latest Feb 5, 2020
@sareh sareh deleted the MediaMessageRefactor branch February 21, 2020 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-media The World Service media stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants