Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Move skip link top so it fits within brand banner #2946

Merged
merged 9 commits into from
Jan 22, 2020
Merged

Move skip link top so it fits within brand banner #2946

merged 9 commits into from
Jan 22, 2020

Conversation

tochwill
Copy link
Contributor

@tochwill tochwill commented Jan 16, 2020 •
edited by DenisHdz
Loading

Resolves #2944

Overall change: Move skip to content link top value to stay within brand banner with height <400px.

Code changes:

  • A bullet point list of key code changes that have been made.
  • When describing code changes, try to communicate how and why you implemented something a specific way, not just what has changed.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@tochwill tochwill self-assigned this Jan 16, 2020
@tochwill tochwill added the ws-home Tasks for the WS Home Team label Jan 16, 2020
DenisHdz
DenisHdz approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍

DenisHdz
DenisHdz suggested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to bump the package-lock.json too.

AlistairGempf
AlistairGempf approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@AlistairGempf AlistairGempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@paruchurisilpa paruchurisilpa self-assigned this Jan 17, 2020
@paruchurisilpa
Copy link
Contributor

Looks good to me..

@tochwill
Copy link
Contributor Author

Just need to update package.json etc after resolving conflicts in the changelog

@PriyaKR PriyaKR merged commit d4096a4 into latest Jan 22, 2020
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jan 23, 2020
Merged
@sareh sareh deleted the skip-link-top branch February 21, 2020 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlistairGempf AlistairGempf AlistairGempf approved these changes

@DenisHdz DenisHdz DenisHdz approved these changes

Assignees

@paruchurisilpa paruchurisilpa

@tochwill tochwill

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip to content link overflows brand container < 400px
5 participants
@tochwill @paruchurisilpa @AlistairGempf @DenisHdz @PriyaKR