This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add clock icon for Radio Schedules #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bopchy
approved these changes
Jan 15, 2020
simonsinclair
approved these changes
Jan 20, 2020
|
The icon looks slightly not circular in firefox browser.If UX are fine i am fine with it. |
|
@PriyaKR I have checked the icon in FireFox 72.0.1 and was not able to reproduce the issue
|
|
I am still seeing that issue may be we can merge this and see how it appears on simorgh pages once we use it in radio schedule components. |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2932
Overall change:
Added a clock icon for Radio Schedules to the
psammead-assets.Code changes: