Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update grid props #2893

Merged
merged 9 commits into from
Jan 10, 2020
Merged

Update grid props #2893

merged 9 commits into from
Jan 10, 2020

Conversation

thekp
Copy link
Contributor

@thekp thekp commented Jan 9, 2020 •
edited
Loading

Following the comment here: #2869 (comment)

Overall change: Update README, to include parentColumns

Code changes:

  • Update psammead-grid readme.
  • Add parentColumns to prop definition in /index.jsx
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@thekp thekp added the most-read Tasks to create Most Read component label Jan 9, 2020
@thekp thekp added this to the Psammead 3.0 milestone Jan 9, 2020
@thekp thekp self-assigned this Jan 9, 2020
@thekp thekp added ws-home Tasks for the WS Home Team and removed most-read Tasks to create Most Read component labels Jan 9, 2020
@thekp thekp marked this pull request as ready for review January 9, 2020 14:53
@EinsteinNjoroge EinsteinNjoroge requested a review from sareh January 9, 2020 15:12
EinsteinNjoroge
EinsteinNjoroge reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one more thing.

We need to add a use-case description for the parentColumns prop.

@thekp thekp requested a review from EinsteinNjoroge January 9, 2020 16:32
@EinsteinNjoroge
update grid documentation
7d794b0 
Signed-off-by: Einstein <forensicslabnet@gmail.com>
@EinsteinNjoroge EinsteinNjoroge mentioned this pull request Jan 10, 2020
Merged
3 tasks
@thekp @EinsteinNjoroge
Update packages/components/psammead-grid/README.md
79776cf 
Co-Authored-By: Einstein Njoroge  <forensicslabnet@gmail.com>
@EinsteinNjoroge EinsteinNjoroge merged commit 16c1103 into latest Jan 10, 2020
@EinsteinNjoroge EinsteinNjoroge deleted the updateGridProps branch January 10, 2020 09:39
This was referenced Jan 10, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oluoluoxenfree oluoluoxenfree oluoluoxenfree approved these changes

@EinsteinNjoroge EinsteinNjoroge EinsteinNjoroge approved these changes

@sareh sareh Awaiting requested review from sareh

Assignees

@thekp thekp

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Psammead 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thekp @oluoluoxenfree @EinsteinNjoroge