This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
AV: iFrame scrollbar media player fix #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarveyPeachey
requested review from
jamesbhobbs,
craigkj,
DenisHdz,
j-pendlebury,
jroebu14 and
sareh
as code owners
RayNjeri
approved these changes
Nov 25, 2019
oluoluoxenfree
approved these changes
Nov 25, 2019
jamesdonoh
approved these changes
Nov 25, 2019
…ar-av-player-fix
…mead into scrollbar-av-player-fix
DenisHdz
approved these changes
Nov 26, 2019
Yep I've added the fix to amp as well |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially bbc/simorgh#4734
Overall change: Fixed visual bug in some browsers that showed the scroll bar for the top iframe of the AV Media Player
Code changes:
scrolling="no"to top iframe for canonical and amp to disable the visual for the iframe scrollbar.Additional Info
This will need to be bumped in Simorgh.