This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisHdz
requested review from
jamesbhobbs,
craigkj,
j-pendlebury,
jroebu14 and
sareh
as code owners
November 25, 2019 11:04
OlgaLyubin
reviewed
Nov 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlgaLyubin It would be solved adding z-index to the |
OlgaLyubin
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on IE 👍
tochwill
reviewed
Nov 26, 2019
OlgaLyubin
reviewed
Nov 26, 2019
tochwill
approved these changes
Nov 26, 2019
Bopchy
approved these changes
Nov 26, 2019
EinsteinNjoroge
approved these changes
Nov 27, 2019
j-pendlebury
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
lgtm |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NUMBER
Overall change:
The skip to content link was in the wrong position on IE:
Code changes:
top
andleft/right
properties to theSkipLink
Script
link to the last storyScriptLink
from a separated folder to reduceindex
length.