Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix skip to content link position #2680

Merged
merged 18 commits into from
Nov 27, 2019
Merged

Fix skip to content link position #2680

merged 18 commits into from
Nov 27, 2019

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Nov 25, 2019

Resolves #NUMBER

Overall change:
The skip to content link was in the wrong position on IE:

skip-to-content-bug

Code changes:

  • Add top and left/right properties to the SkipLink
  • Add Script link to the last story
  • Export ScriptLink from a separated folder to reduce index length.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Nov 25, 2019
@DenisHdz DenisHdz self-assigned this Nov 25, 2019
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rtl it seems like the text from the ScriptLink is overflowing the Skip to content
Screenshot 2019-11-25 at 11 35 26

@DenisHdz
Copy link
Contributor Author

DenisHdz commented Nov 26, 2019

@OlgaLyubin It would be solved adding z-index to the SkipLink, but we have decided to put it on the right side for rtl services, so it should be fine.

Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on IE 👍

Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jamesbrumpton
Copy link
Contributor

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants