This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good. It adds variant support for Serbian/UKChina/Zhongwen.
Though I also worked on part of it with @thekp, so it'd be good to get other eyes on it too.
FK78
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch must update CHANGELOG.md in psammead-storybook-helpers
Branch must update package-lock.json in psammead-storybook-helpers
Branch must update package.json in psammead-storybook-helpers
FK78
approved these changes
Nov 25, 2019
jroebu14
reviewed
Nov 25, 2019
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
jroebu14
reviewed
Nov 25, 2019
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
jroebu14
reviewed
Nov 25, 2019
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
jroebu14
reviewed
Nov 25, 2019
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
…m/bbc/psammead into add-service-variant-compatiablity
sareh
reviewed
Nov 25, 2019
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx
Outdated
Show resolved
Hide resolved
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.test.jsx
Outdated
Show resolved
Hide resolved
packages/utilities/psammead-storybook-helpers/src/withServicesKnob.jsx
Outdated
Show resolved
Hide resolved
…Knob.test.jsx Co-Authored-By: Einstein Njoroge <forensicslabnet@gmail.com>
…Knob.test.jsx Co-Authored-By: Einstein Njoroge <forensicslabnet@gmail.com>
jroebu14
approved these changes
Nov 26, 2019
This was referenced Nov 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2667
Overall change: Updated our example data for the storybook-helper package by adding variant prop into the storyProps object.
Code changes: