Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add service variant compatiablity #2668

Merged
merged 23 commits into from
Nov 26, 2019
Merged

Conversation

thekp
Copy link
Contributor

@thekp thekp commented Nov 22, 2019

Resolves #2667

Overall change: Updated our example data for the storybook-helper package by adding variant prop into the storyProps object.

Code changes:

  • updated the text-variants file to include a variant and service value for variant service.
  • added logic to the withServiceKnob to pass a variant when it exists
  • made the code more readable by adding constants at the top of the file
  • install ramda to root package.json and use path to safely check for values in object

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. It adds variant support for Serbian/UKChina/Zhongwen.
Though I also worked on part of it with @thekp, so it'd be good to get other eyes on it too.

Copy link
Contributor

@FK78 FK78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch must update CHANGELOG.md in psammead-storybook-helpers
Branch must update package-lock.json in psammead-storybook-helpers
Branch must update package.json in psammead-storybook-helpers

@thekp thekp requested a review from jroebu14 November 25, 2019 11:57
@thekp thekp requested a review from jroebu14 November 25, 2019 16:15
thekp and others added 3 commits November 26, 2019 09:58
…Knob.test.jsx

Co-Authored-By: Einstein Njoroge  <forensicslabnet@gmail.com>
…Knob.test.jsx

Co-Authored-By: Einstein Njoroge  <forensicslabnet@gmail.com>
@thekp thekp merged commit 7114b81 into latest Nov 26, 2019
@thekp thekp deleted the add-service-variant-compatiablity branch November 26, 2019 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make withServiceKnobs() variant compatible
5 participants