This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
AV: Fix HCM for guidance background colour #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarveyPeachey
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
|
Spoke to @greenc05 and she's happy with the HCM changes for guidance. She also discovered an issue with the play button icon on the |
12
approved these changes
Nov 7, 2019
I'll make a PR when this is merged, I just need to make sure this merges before I bump it in Simorgh. |
ryanmccombe
approved these changes
Nov 8, 2019
…idance-hcm. Repruned in content for guidance for a11y purposes
simonsinclair
suggested changes
Nov 11, 2019
packages/components/psammead-media-player/src/Guidance/index.jsx
Outdated
Show resolved
Hide resolved
packages/components/psammead-media-player/src/Guidance/index.jsx
Outdated
Show resolved
Hide resolved
packages/components/psammead-media-player/src/Guidance/index.jsx
Outdated
Show resolved
Hide resolved
packages/components/psammead-media-player/src/Guidance/index.jsx
Outdated
Show resolved
Hide resolved
simonsinclair
approved these changes
Nov 11, 2019
|
LGTM.. |
|
Moved to Ready to Code Review as it says Code owner review required..Can be moved straight to merge once the review happens as this has been tested.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2572
Overall change: Fixed a11y issue with image placeholder not showing when in High Contrast Mode in Windows for IE11 and Firefoxes colour preferences.
Code changes: