This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Explicitly set h1 styles display and font weight #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlee11
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
added 5 commits
November 6, 2019 15:53
…thub.com:bbc/psammead into explicitly-set-h1-styles-display-and-font-weight
4 tasks
dr3
suggested changes
Nov 6, 2019
packages/components/psammead-headings/src/__snapshots__/index.test.jsx.snap
Show resolved
Hide resolved
dr3
approved these changes
Nov 6, 2019
ryanmccombe
approved these changes
Nov 7, 2019
12
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to xxx
Overall change: Explicitly adds
font-weight: 500anddisplay: blockwhich are defaults on<h1>, so that we can use this componentas="strong"for theOnScreenHeadline[ ] This PR requires manual testing