Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

AV: Add empty img alt tag to placeholder #2476

Merged
merged 9 commits into from
Nov 1, 2019
Merged

Conversation

HarveyPeachey
Copy link
Contributor

Resolves #1840

Overall change: Updated image alt to be empty to follow desired behaviour for screen reader

Code changes:

  • Replaced alt="Image Alt" with alt="" on video image placeholder
  • Updated snapshots

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@HarveyPeachey
Copy link
Contributor Author

HarveyPeachey commented Oct 23, 2019

Requires a11y swarm: Testing on Storybook Psammead MediaPlayer

A11y Swarm
https://bbc.github.io/accessibility-news-and-you/accessibility-news-and-testers

Screen Readers (IE11):

  • ZoomText Magnifier/Reader - 8, 9, 10 - MouseHover, Speakit, AppRdr tool doesn't say anything when placeholder image is clicked only when the play button is clicked.
  • Dragon NaturallySpeaking
  • JAWS - Doesn't read out any alt on the image skips straight to play button.
  • Read&Write - N/A

Mac, iOS, and Android:

  • VoiceOver iOS (iPhone/iPad) - Doesn't read out any alt on the image skips straight to play button.
  • VoiceOver OS (Mac) - Doesn't read out any alt on the image skips straight to play button.
  • TalkBack - Ray (Chrome on Android)

Copy link
Contributor

@jamesdonoh jamesdonoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something nice and easy for a change :-)

@HarveyPeachey HarveyPeachey merged commit 5b23edd into latest Nov 1, 2019
@HarveyPeachey HarveyPeachey deleted the placeholder-alt-text branch November 1, 2019 12:00
@jamesdonoh jamesdonoh mentioned this pull request Nov 1, 2019
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
articles-av-epic ws-articles Tasks for the WS Articles Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AV: Placeholder image alt text
5 participants