This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Media player audio skin story placeholder #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlee11
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
pjlee11
commented
Oct 16, 2019
ryanmccombe
approved these changes
Oct 18, 2019
EinsteinNjoroge
approved these changes
Oct 18, 2019
dr3
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bbc/simorgh#4175
Overall change: Updates the story to use the new
placeholderSrcfor the Media Player component with the Audio skin for AMP.[ ] Automated jest tests added (for new features) or updated (for existing features)npm run storybookensuring a grey placeholder is provided prior to the iframe loading into the page on the story Media Player -> Audio Skin AMP