This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update Grid Stories #2315
Merged
Update Grid Stories #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisHdz
requested review from
jamesbhobbs,
dr3,
j-pendlebury and
jroebu14
as code owners
tochwill
reviewed
Oct 15, 2019
tochwill
approved these changes
Oct 15, 2019
EinsteinNjoroge
approved these changes
Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2287 and #2286
Overall change:
Fix and clean up Gris stories.
Code changes:
Simple example using gelGutters and gelMarginsstory as it is basically the same asSlice layout for 6 or 10 items.Normal slice layout for 1 or 5 itemsstory asNormal slice layout for 2, 6 or 10 itemswhere the<ExampleImage />and the<ExampleParagraph />are contained within just one Grid item, instead of being separated in two Grid items within a Grid parent, otherwise that kind of layout breaks on IE, because of a wrongwidthcalculation.I opened a separate issue to fix this if it is necessary, but we need to double-check with Sareh first.