Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

define placeholderSrc #2297

Merged
merged 3 commits into from
Oct 2, 2019
Merged

define placeholderSrc #2297

merged 3 commits into from
Oct 2, 2019

Conversation

FK78
Copy link
Contributor

@FK78 FK78 commented Oct 2, 2019

Resolves #2295

Overall change: Defined missing prop.

Code changes:

  • placeholderSrc defined.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@FK78 FK78 added bug Something isn't working simorgh-core-stream Heracles labels Oct 2, 2019
@FK78 FK78 added this to the Psammead 2.0 milestone Oct 2, 2019
@FK78 FK78 self-assigned this Oct 2, 2019
@FK78 FK78 changed the title add placeholderSrc defined placeholderSrc Oct 2, 2019
@FK78 FK78 changed the title defined placeholderSrc define placeholderSrc Oct 2, 2019
samora
samora approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@samora samora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@FK78 FK78 merged commit 27c1339 into latest Oct 2, 2019
@FK78 FK78 deleted the react-prop-type-warning-src branch October 2, 2019 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samora samora samora approved these changes

@dr3 dr3 dr3 approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@jroebu14 jroebu14 Awaiting requested review from jroebu14

@sareh sareh Awaiting requested review from sareh

Assignees

@FK78 FK78

Labels
bug Something isn't working simorgh-core-stream
Projects
None yet
Milestone
Psammead 2.0
Development

Successfully merging this pull request may close these issues.

Fix React warning
3 participants
@FK78 @samora @dr3