This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Remove scrolling="no" from Media Player #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlee11
added
ws-articles
pjlee11
requested review from
jamesbhobbs,
dr3,
j-pendlebury,
jroebu14 and
sareh
as code owners
pjlee11
commented
Oct 1, 2019
3 tasks
pjlee11
changed the title
1 task
pjlee11
changed the title
pjlee11
commented
Oct 1, 2019
pjlee11
commented
Oct 1, 2019
packages/components/psammead-media-player/src/Amp/index.test.jsx
Outdated
Show resolved
Hide resolved
pjlee11
commented
Oct 1, 2019
packages/components/psammead-media-player/src/Canonical/index.test.jsx
Outdated
Show resolved
Hide resolved
pjlee11
commented
Oct 1, 2019
packages/components/psammead-media-player/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
added 6 commits
October 1, 2019 16:17
…/psammead into remove-scrolling-no-for-a11y-reasons
…/psammead into remove-scrolling-no-for-a11y-reasons
…g-no-for-a11y-reasons
pjlee11
commented
Oct 1, 2019
| @@ -15,7 +15,7 @@ storiesOf('Components|Media Player', module) | |||
| .add('AMP', () => ( | |||
| <AmpMediaPlayer | |||
| isAmp | |||
| src="https://www.test.bbc.co.uk/ws/av-embeds/articles/c3wmq4d1y3wo/p01k6msp" | |||
| src="https://www.test.bbc.co.uk/ws/av-embeds/articles/c3wmq4d1y3wo/p01k6msp/amp" | |||
There was a problem hiding this comment.
Bug, might as well fix here
ryanmccombe
approved these changes
Oct 2, 2019
packages/components/psammead-media-player/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
packages/components/psammead-media-player/src/index.stories.jsx
Outdated
Show resolved
Hide resolved
12
changed the title
title prop for a11y reasons
pjlee11
changed the title
title prop for a11y reasons
simonsinclair
approved these changes
Oct 2, 2019
dr3
approved these changes
Oct 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2278
Overall change: Removes
scrolling="no"attribute.Test this by regression checking
npm run storybook.