This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Brand - new backgroundColour & logoColour props #2127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
requested review from
jamesbhobbs,
dr3,
j-pendlebury and
jroebu14
as code owners
September 13, 2019 16:34
3 tasks
DenisHdz
reviewed
Sep 16, 2019
@@ -57,6 +62,8 @@ const Header = (product, serviceName) => ( | |||
minWidth={180} | |||
svg={igbo} | |||
url="https://www.bbc.co.uk/news" | |||
backgroundColour={backgroundColour} | |||
logoColour={logoColour} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Have updated it. I used the labels Background colour
and Logo colour
to keep them in keeping with the other knob labels that refer to the prop name.
DenisHdz
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
EinsteinNjoroge
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jroebu14
approved these changes
Sep 16, 2019
Happy for this to be merged 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ticket
A new brand colour will be needed shortly: #2120
We could build a theming object and pass that in, but in the case of Brand it's simpler to pass in just these two props instead.
Overall change: Update brand to take in colour props
backgroundColour
&logoColour
. These are required props since there is no default colour, so this is a major version increase.Code changes:
Storybook with standard colours:
Can change the colours using the Storybook color add-on knob
Localhost Storybook link: http://localhost:8180/?path=/story/components-brand--with-brand-link