Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Override moment formats #2114

Merged
merged 25 commits into from
Sep 16, 2019
Merged

Override moment formats #2114

merged 25 commits into from
Sep 16, 2019

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Sep 12, 2019 •
edited
Loading

Resolves #2099

Overall change:
Update moment to have the correct format for Brasil, Russian, Serbian and Ukrainian.

Code changes:

  • Add pt-br, ru, sr, sr-cyrl and uk files to psammead-locales.
  • Use moment.updateLocale to override the moment locales.
  • Bump psammead-locales
  • Update README
  • I have assigned myself to this PR and the corresponding issues
  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Sep 12, 2019
@DenisHdz DenisHdz self-assigned this Sep 12, 2019
@DenisHdz DenisHdz requested a review from a user September 16, 2019 08:32
@staylos92 staylos92 self-assigned this Sep 16, 2019
@staylos92
Copy link
Contributor

LGTM 👍

@DenisHdz DenisHdz merged commit 095f49d into latest Sep 16, 2019
@DenisHdz DenisHdz deleted the override-moment-formats branch September 16, 2019 15:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@jroebu14 jroebu14 Awaiting requested review from jroebu14

@sareh sareh Awaiting requested review from sareh

Assignees

@staylos92 staylos92

@DenisHdz DenisHdz

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override moment formats
3 participants
@DenisHdz @staylos92 @dr3