Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Change strings to booleans #1806

Merged
merged 9 commits into from
Aug 19, 2019
Merged

Change strings to booleans #1806

merged 9 commits into from
Aug 19, 2019

Conversation

FK78
Copy link
Contributor

@FK78 FK78 commented Aug 19, 2019 •
edited
Loading

Resolves #1787

Overall change: Strings to booleans

Code changes:

  • Changed "true" to true in multiple files
  • I have assigned myself to this PR and the corresponding issues
  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@FK78 FK78 requested review from andrew-nowak and dr3 August 19, 2019 08:16
@FK78 FK78 self-assigned this Aug 19, 2019
@FK78 FK78 added bug Something isn't working simorgh-core-stream labels Aug 19, 2019
@FK78 FK78 requested a review from dr3 August 19, 2019 08:57
@FK78 FK78 requested a review from chris-hinds August 19, 2019 09:21
@chris-hinds
Copy link
Contributor

This doesnt need testing.

@FK78 FK78 merged commit 6ef7564 into latest Aug 19, 2019
@FK78 FK78 deleted the issue-1787 branch August 19, 2019 09:30
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Sep 11, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dr3 dr3 dr3 approved these changes

@chris-hinds chris-hinds chris-hinds approved these changes

@andrew-nowak andrew-nowak Awaiting requested review from andrew-nowak

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@FK78 FK78

Labels
bug Something isn't working simorgh-core-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package.json should use boolean not string
3 participants
@FK78 @chris-hinds @dr3