-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I have been comparing all the values with the ones UX added in the spreadsheet and I found several differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Dennis' comment, looks good - LGTM
@DenisBBC Thanks for the detailed review with all of your suggestions, Denis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for confirming this 👍
…ghts for non-latin scripts Co-Authored-By: Denis Hernandez <46446236+DenisBBC@users.noreply.github.com>
This has been UX reviewed and approved. |
Moving this to Ready for merge without testing as this would be tested once #1508 is done |
Part of #1508
Overall change: Add additional GEL Type sizes for large contexts (Atlas, Elephant, Imperial, Royal, Foolscap) Sizes here: https://www.bbc.co.uk/gel/guidelines/typography#additional-type-sizes-for-larger-contexts
UX context: When pairing with UX, it was decided that to start with all non-Latin font-sizes and line heights will initially be the same as those for Latin. Then they will stress-test these types with different scripts and where relevant ask for changes in a separate issue.
Code changes:
getAtlas
etc. which can be used by others within components.Testing Note: this first PR does not update Storybook with the typography! http://localhost:8180/?path=/story/typography--canon this needs to be carried out with an update to
psammead-styles
in a separate PR after thisgel-foundations
change has been merged. There will be a second PR for this issue #1508 to be complete.